lytt925 opened a new pull request, #23699: URL: https://github.com/apache/kafka/pull/23699
Follow-up to [#23513](https://github.com/apache/kafka/pull/23513#pullrequestreview-5404718402) to address the review comments. ClusterInstance#createTopic and #createTopicWithAssignment did not wait for the CreateTopics result. If the creation failed, the real error was hidden by the 60 second waitTopicCreation timeout, or ignored if the topic already existed. They now call get() so that the real error can be propagated. These are setup helpers that are expected to succeed, so ExecutionException and InterruptedException are wrapped in RuntimeException, and callers no longer need to declare them. Other cleanups: - Remove assertDoesNotThrow wrappers and throws clauses that only existed because of the checked exceptions. - Call ClusterInstance#createTopic directly instead of pass-through private helpers (e.g. LogDirsCommandTest, DescribeConsumerGroupTest). - Inline single-use local variables in TopicCommandTest and drop a redundant Map.of() in RemoteTopicCrudTest. - PlaintextConsumerTest#testSeek created the same topic twice; the duplicate call is removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
