lytt925 commented on code in PR #23699:
URL: https://github.com/apache/kafka/pull/23699#discussion_r4183731836
##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/ClusterInstance.java:
##########
@@ -329,26 +329,36 @@ default void waitTopicDeletion(String topic) throws
InterruptedException {
), "Failed to hard-delete the delete directory");
}
- default void createTopic(String topicName, int partitions, short replicas)
throws InterruptedException {
+ default void createTopic(String topicName, int partitions, short replicas)
{
createTopic(topicName, partitions, replicas, Map.of());
}
- default void createTopic(String topicName, int partitions, short replicas,
Map<String, String> props) throws InterruptedException {
+ default void createTopic(String topicName, int partitions, short replicas,
Map<String, String> props) {
try (Admin admin = admin()) {
- admin.createTopics(List.of(new NewTopic(topicName, partitions,
replicas).configs(props)));
+ admin.createTopics(List.of(new NewTopic(topicName, partitions,
replicas).configs(props))).all().get();
waitTopicCreation(topicName, partitions);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new RuntimeException("Failed to create topic " + topicName,
e);
+ } catch (ExecutionException e) {
Review Comment:
Thanks for pointing this out. Updated
##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/ClusterInstance.java:
##########
@@ -329,26 +329,36 @@ default void waitTopicDeletion(String topic) throws
InterruptedException {
), "Failed to hard-delete the delete directory");
}
- default void createTopic(String topicName, int partitions, short replicas)
throws InterruptedException {
+ default void createTopic(String topicName, int partitions, short replicas)
{
createTopic(topicName, partitions, replicas, Map.of());
}
- default void createTopic(String topicName, int partitions, short replicas,
Map<String, String> props) throws InterruptedException {
+ default void createTopic(String topicName, int partitions, short replicas,
Map<String, String> props) {
try (Admin admin = admin()) {
- admin.createTopics(List.of(new NewTopic(topicName, partitions,
replicas).configs(props)));
+ admin.createTopics(List.of(new NewTopic(topicName, partitions,
replicas).configs(props))).all().get();
waitTopicCreation(topicName, partitions);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new RuntimeException("Failed to create topic " + topicName,
e);
+ } catch (ExecutionException e) {
Review Comment:
Thanks for pointing this out! Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
