chia7712 commented on code in PR #23557:
URL: https://github.com/apache/kafka/pull/23557#discussion_r4191981883
##########
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/unsecured/OAuthBearerUnsecuredLoginCallbackHandler.java:
##########
@@ -217,6 +223,16 @@ private void handleTokenCallback(OAuthBearerTokenCallback
callback) {
}
}
+ /**
+ * Returns true if any module option is relevant to unsecured token
creation.
+ * Options that do not start with the {@code unsecuredLogin} prefix (e.g.
+ * {@code ssl.*} options used for JWKS endpoint TLS trust) are not related
to
+ * unsecured token minting and should not trigger token creation.
+ */
+ private boolean hasUnsecuredLoginOptions() {
Review Comment:
I was wondering whether this fix is worth it, since this class is marked as
testing-purpose and users can implement a custom handler for the tokenless
logic. That said, the default path should not break on valid ssl.* options.
Anyway, I have opened KAFKA-21221 to address it properly as a follow-up. We
can get this merged as a workaround for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
