viktorsomogyi commented on code in PR #23557:
URL: https://github.com/apache/kafka/pull/23557#discussion_r4194109147
##########
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/unsecured/OAuthBearerUnsecuredLoginCallbackHandler.java:
##########
@@ -180,12 +180,14 @@ public void close() {
private void handleTokenCallback(OAuthBearerTokenCallback callback) {
if (callback.token() != null)
throw new IllegalArgumentException("Callback had a token already");
- if (moduleOptions.isEmpty()) {
+ if (!hasUnsecuredLoginOptions()) {
Review Comment:
It also makes it possible for typos to get through, like if an option starts
with "unsecureLogin" (missing d from unsecure**d**), which would materialize
sometime later in this path. It's not a serious issue though because this class
is only used for testing as I understand it, but perhaps we could log what was
ignored, so it's easier to trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
