muralibasani commented on code in PR #23557:
URL: https://github.com/apache/kafka/pull/23557#discussion_r4199359760
##########
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/unsecured/OAuthBearerUnsecuredLoginCallbackHandler.java:
##########
@@ -180,12 +180,14 @@ public void close() {
private void handleTokenCallback(OAuthBearerTokenCallback callback) {
if (callback.token() != null)
throw new IllegalArgumentException("Callback had a token already");
- if (moduleOptions.isEmpty()) {
+ if (!hasUnsecuredLoginOptions()) {
Review Comment:
Thanks @viktorsomogyi for the review.
And yea agree with this. Logged a warning now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
