gabriellefu commented on code in PR #23165:
URL: https://github.com/apache/kafka/pull/23165#discussion_r4200264242


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2270,9 +2268,10 @@ private CoordinatorResult<StreamsGroupHeartbeatResult, 
CoordinatorRecord> stream
             assignmentUpdate = AssignmentUpdate.RECOMPUTE;
         }
 
-        // Check if assignment configurations have changed
-        Map<String, String> currentAssignmentConfigs = 
streamsGroupAssignmentConfigs(groupId);
-        Map<String, String> storedAssignmentConfigs = 
group.lastAssignmentConfigs();
+        // Check if assignment configurations have changed. A group with no 
recorded configs holds the defaults,

Review Comment:
   we don't know, records written by older maybe not having 
LastAssignmentConfigs, so we assume the defaults.  Then when the broker just 
version bump, we only rebalancing when the new config is not defaults.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to