gabriellefu commented on code in PR #23165:
URL: https://github.com/apache/kafka/pull/23165#discussion_r4200219201


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##########
@@ -265,10 +265,10 @@ private record RefinedAssignment(int assignmentEpoch, 
Map<String, TasksTuple> as
     private final TimelineObject<Optional<ConfiguredTopology>> 
configuredTopology;
 
     /**
-     * The last used assignment configurations for this streams group.
+     * The last used assignment configurations for this streams group; the 
defaults until any were recorded.

Review Comment:
   i have changed it, here means if group metadata record has none(written by 
the older broker), then we just use default config for it, replias=0,tags="". 
so it won't trigger a rebalancing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to