gabriellefu commented on code in PR #23165:
URL: https://github.com/apache/kafka/pull/23165#discussion_r4200347567


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -24178,7 +24177,91 @@ public void 
testStreamsGroupEpochIncreaseWithNumStandbyReplicasConfigChanges() {
         StreamsGroup group = 
context.groupMetadataManager.streamsGroup(groupId);
         int newGroupEpoch = group.groupEpoch();
         assertEquals(11, newGroupEpoch);
-        assertEquals("2", 
group.lastAssignmentConfigs().get("num.standby.replicas"));
+        assertEquals(2, group.lastAssignmentConfigs().numStandbyReplicas());
+    }
+
+    @Test
+    public void 
testStreamsGroupEpochDoesNotIncreaseWhenEveryAssignmentConfigIsAtItsDefault() {
+        // A group that sets nothing must compare equal to a record without 
configs, or upgrading the
+        // broker rebalances every group.

Review Comment:
   I have reorignize my words, it's like 
   if new configs are introduced in new broker version, but in the old record 
it doesn't exist. so when we upgrade the broker, we consider the value of those 
"new configs" are default, and as long as those configs are not set during 
broker upgrade, we won't trigger a new rebalance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to