lucasbru commented on PR #23768: URL: https://github.com/apache/kafka/pull/23768#issuecomment-6110152029
Hi @chickenchickenlove ! I think you correctly spotted a problem here. I wonder if you considered following the consumer group protocol. It uses a "full heartbeat" condition to trigger a full response. I suppose the problem with copying that behavior does have the problem, that we do not (currently) allow the topology to be sent again. So we couldn't implement the consumer group approach directly - at least not remaining compatible with existing clients. So I think you approach here is very pragmatic and will resolve the problem for existing clients. Have you considered also changing the client to resend more fields, not just the assignment, after a heartbeat failure, to follow the consumer group example more closely? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
