ezhou413 commented on code in PR #23483:
URL: https://github.com/apache/kafka/pull/23483#discussion_r4265601217
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/ChunkedRecordAccumulator.java:
##########
@@ -188,10 +181,10 @@ public RecordAppendResult append(String topic,
nowMs = time.milliseconds();
} else if (appendResult.needsNewBatch() && newBatch == null) {
// The open batch is done (e.g., full, closed) so start a
new one. Size it for
- // this first record with the same estimator the full
strategy uses
- // (RecordAccumulator.append), but reserve only enough for
the record rather than
- // a whole batch.size.
- // TODO: review when compression is supported.
+ // this first record only (not a whole batch.size), to the
uncompressed upper bound
Review Comment:
Got it, will change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
