ezhou413 commented on code in PR #23483:
URL: https://github.com/apache/kafka/pull/23483#discussion_r4319301035
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java:
##########
@@ -226,8 +226,8 @@ public ByteBuffer allocate(int size, long maxTimeToBlockMs)
throws InterruptedEx
* @return the nanos actually waited, for the caller to deduct from its
blocking budget
* @throws KafkaException if the pool was closed during the wait
* @throws BufferExhaustedException if the wait timed out; the
buffer-exhausted metric is recorded
- * only when {@code recordExhaustedOnTimeout} is true (the
incremental extension path
- * recovers without dropping the record, so it records the drop
itself if needed)
+ * only when {@code recordExhaustedOnTimeout} is true (the
incremental strategy's new-batch
+ * caller in {@link ChunkedRecordAccumulator} records the drop
itself)
Review Comment:
Updated this for clarity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
