liuliuOD commented on code in PR #23856:
URL: https://github.com/apache/kafka/pull/23856#discussion_r4307669122
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -6942,7 +6942,15 @@ public void onLoaded() {
log.info("Loaded consumer group {} with {} members.",
groupId, consumerGroup.members().size());
consumerGroup.members().forEach((memberId, member) -> {
log.debug("Loaded member {} in consumer group {}.",
memberId, groupId);
- scheduleConsumerGroupSessionTimeout(groupId, memberId);
+
+ if (member.useClassicProtocol() &&
member.classicProtocolSessionTimeout().isPresent()) {
Review Comment:
Is the fallback for classic members intentional? Since
`classicProtocolSessionTimeout()` always has a value when
`useClassicProtocol()` is true, could we drop the `isPresent()` check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
