dajac commented on code in PR #23856:
URL: https://github.com/apache/kafka/pull/23856#discussion_r4326387605
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -6942,7 +6942,15 @@ public void onLoaded() {
log.info("Loaded consumer group {} with {} members.",
groupId, consumerGroup.members().size());
consumerGroup.members().forEach((memberId, member) -> {
log.debug("Loaded member {} in consumer group {}.",
memberId, groupId);
- scheduleConsumerGroupSessionTimeout(groupId, memberId);
+
+ if (member.useClassicProtocol() &&
member.classicProtocolSessionTimeout().isPresent()) {
+ scheduleConsumerGroupSessionTimeout(
+ groupId,
+ memberId,
+ member.classicProtocolSessionTimeout().get());
Review Comment:
nit1: It seems that we could use the following and remove the if statement
`member.classicProtocolSessionTimeout().orElse(consumerGroupSessionTimeoutMs(groupId))`.
Would it work?
nit2: Could you put the closing parenthesis on a new line to follow the
existing style in the file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
