gitedmond commented on PR #23691: URL: https://github.com/apache/kafka/pull/23691#issuecomment-6253313354
@squah-confluent Thanks for the detailed follow-up. I've pushed the fixes in e2b8ee3b59. I removed the redundant Python setup step and reverted the logger rename. The formatter now preserves the additional list markers and timeline lines, wraps prose containing inline code, underscores, and links, handles adjacent trailers independently, and normalizes line endings to LF. The tests now cover these cases and check idempotence throughout. Unfenced benchmark output still follows prose wrapping, but is stable after one pass; code fences preserve aligned columns. I also updated the PR description and repaired its attribution trailers, retaining all three reviewer credits. Validation: - All 15 test methods pass locally on Python 3.14 with `python -B -S -m unittest discover -s .github/scripts -p test_pr_format.py -v`. - The same expanded suite produces 17 failing assertions against the previous formatter, with no errors. - Python compilation, `git diff --check`, and mocked CLI checks for unchanged bodies, CRLF-only changes, and prose reflow pass. - The new [PR Formatter Tests](https://github.com/apache/kafka/actions/runs/39152639792) and [CI](https://github.com/apache/kafka/actions/runs/39152639888) runs currently report `action_required`, with no job results available yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
