chia7712 commented on code in PR #23696:
URL: https://github.com/apache/kafka/pull/23696#discussion_r4315964067
##########
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##########
@@ -133,8 +133,9 @@ public Set<String> listClientMetricsResources() {
}
public void updateSubscription(String subscriptionName, Properties
properties) {
- // Validate the subscription properties.
- ClientMetricsConfigs.validate(subscriptionName, properties);
+ // Reapplying an already-committed config, not admitting a new one, so
pass properties
Review Comment:
It is weird that we are lenient only for regex. The method validateConfigs
still validates other configs. If we trust the configs from the metadata, the
whole validateConfigs should be skipped.
@apoorvmittal10 @ojasvajain @AndrewJSchofield WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
