ojasvajain commented on code in PR #23696:
URL: https://github.com/apache/kafka/pull/23696#discussion_r4336357923
##########
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##########
@@ -133,8 +133,9 @@ public Set<String> listClientMetricsResources() {
}
public void updateSubscription(String subscriptionName, Properties
properties) {
- // Validate the subscription properties.
- ClientMetricsConfigs.validate(subscriptionName, properties);
+ // Reapplying an already-committed config, not admitting a new one, so
pass properties
Review Comment:
Addessed this in a5b37bac7102d7604aac7b5ad7c9838eadc1ae7e. There was a test
case that relied on the validate() call, I have modified its expectations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
