chia7712 commented on code in PR #24005:
URL: https://github.com/apache/kafka/pull/24005#discussion_r4429726749
##########
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##########
@@ -311,8 +311,10 @@ static class PartitionDescription {
this.reassignment = reassignment;
}
+ // Effective min ISR, capped at the replica count like
Partition#effectiveMinIsr on the broker.
Review Comment:
This logic is gated on the metadata version (MetadataVersion#isElrSupported)
on the broker side, so it would be incorrect if the target cluster is running
an older MV. Maybe we need to use describeFeatures to detect the finalized
metadata.version and then adjust the behaviour here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
