muralibasani commented on code in PR #24005:
URL: https://github.com/apache/kafka/pull/24005#discussion_r4432177642
##########
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##########
@@ -311,8 +311,10 @@ static class PartitionDescription {
this.reassignment = reassignment;
}
+ // Effective min ISR, capped at the replica count like
Partition#effectiveMinIsr on the broker.
Review Comment:
Thanks @chia7712 , good one handling old clusters.
Just noticed that the cap in Partition#effectiveMinIsr was added in the
3.7.0 release. (KAFKA-15583, #14594)
https://github.com/apache/kafka/pull/14594/changes#diff-16590fdbe6661105c6faa87d68e39a553e66b34ee0a6d0b14a48d02e273bab4fR370
3.6.x still looks good, comparing with raw min.insync.replicas
I am thinking of adding condition when finalized metadata.version >=
3.7-IV0(IBP_3_7_IV0) on describeFeatures, which will take care of all brokers
are >= 3.7.
If MV is lower or other cases, it falls back to raw value.
Pls suggest if it's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
