feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429083564
##########
File path:
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
##########
@@ -1138,7 +1165,7 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
val validMemberFuture = removeMembersResult.memberResult(new
MemberToRemove(testInstanceId))
assertNull(validMemberFuture.get())
- // The group should contain no member now.
+ // The group's active members number should decrease by 1
Review comment:
Removed, but curious about the reason :)
##########
File path:
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
##########
@@ -1147,6 +1174,16 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
assertEquals(testGroupId, testGroupDescription.groupId)
assertFalse(testGroupDescription.isSimpleConsumerGroup)
+ assertEquals(consumerSet.size -1,
testGroupDescription.members().size())
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
