feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429086933
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java
##########
@@ -46,26 +46,42 @@
* If not, the first member error shall be returned.
*/
public KafkaFuture<Void> all() {
- final KafkaFutureImpl<Void> result = new KafkaFutureImpl<>();
- this.future.whenComplete((memberErrors, throwable) -> {
- if (throwable != null) {
- result.completeExceptionally(throwable);
- } else {
- for (MemberToRemove memberToRemove : memberInfos) {
- if (maybeCompleteExceptionally(memberErrors,
memberToRemove.toMemberIdentity(), result)) {
- return;
+ if (removeAll()) {
Review comment:
Yeah, just as you surmised, but you are right, we should scan the
removal results as well. Slightly updated, followed the convention of
`non-removeAll` scenario, just return with the first exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
