[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

[GitBox]

feyman2016 commented on a change in pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#discussion_r429084219



##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -186,9 +190,15 @@ private void validateNoActiveConsumers(final String 
groupId,
         final List<MemberDescription> members =
             new 
ArrayList<>(describeResult.describedGroups().get(groupId).get().members());
         if (!members.isEmpty()) {
-            throw new IllegalStateException("Consumer group '" + groupId + "' 
is still active "
-                    + "and has following members: " + members + ". "
-                    + "Make sure to stop all running application instances 
before running the reset tool.");
+            if (options.has(forceOption)) {
+                System.out.println("Force deleting all active members in the 
group: " + groupId);
+                adminClient.removeMembersFromConsumerGroup(groupId, new 
RemoveMembersFromConsumerGroupOptions()).all();

Review comment:
       Agreed, fixed 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org