xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429495778
########## File path: clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetricsContext.java ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.metrics; + +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; + +/** + * A implementation of MetricsContext, it encapsulates required metrics context properties for Kafka services and clients + */ +public class KafkaMetricsContext implements MetricsContext { + /** + * Client or Service's metadata map. + */ + private Map<String, String> metadata = new HashMap<>(); Review comment: > Thanks for the patch @xiaodongdu! > > I reviewed the client and broker sections of code as well as the new interface. Comments inline. > > I think the ability to include "metrics.context.*" values as config is generally useful. Is it worth doing this for the broker as well? > > Also, in case you didn't know, you can use [Markdown](https://guides.github.com/features/mastering-markdown/) in the PR description to format it and make it a little more readable. Moved String constants into KafkaConfig. Also change this to be final. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
