xiaodongdu commented on a change in pull request #8691:
URL: https://github.com/apache/kafka/pull/8691#discussion_r429510931
##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -129,7 +129,10 @@ class KafkaServer(val config: KafkaConfig, time: Time =
Time.SYSTEM, threadNameP
private var shutdownLatch = new CountDownLatch(1)
+ //properties for MetricsContext
Review comment:
From his comments: "I think the ability to include "metrics.context.*"
values as config is generally useful. Is it worth doing this for the broker as
well?"
Looks like I misunderstood what he meant. Just talked to him on slack. I'll
revert that change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
