xvrl commented on a change in pull request #8691:
URL: https://github.com/apache/kafka/pull/8691#discussion_r429503342
##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -129,7 +129,10 @@ class KafkaServer(val config: KafkaConfig, time: Time =
Time.SYSTEM, threadNameP
private var shutdownLatch = new CountDownLatch(1)
+ //properties for MetricsContext
Review comment:
any reason you moved some but not jmxPrefix? I think it would make sense
to keep all the metrics context constants in one place. I didn't see any
comment from @mumrah suggesting to move them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
