ijuma commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r432987691
##########
File path: tests/kafkatest/tests/core/replication_test.py
##########
@@ -126,9 +126,11 @@ def min_cluster_size(self):
security_protocol="SASL_SSL",
client_sasl_mechanism="SCRAM-SHA-256",
interbroker_sasl_mechanism="SCRAM-SHA-512")
@matrix(failure_mode=["clean_shutdown", "hard_shutdown", "clean_bounce",
"hard_bounce"],
security_protocol=["PLAINTEXT"], broker_type=["leader"],
compression_type=["gzip"])
+ @matrix(failure_mode=["clean_shutdown", "hard_shutdown", "clean_bounce",
"hard_bounce"],
+ security_protocol=["SSL"], broker_type=["leader"],
compression_type=["gzip"], tls_version=["TLSv1.2", "TLSv1.3"])
Review comment:
I think we can change one of the `SASL_SSL` entries to include multiple
TLS versions. This way, we also verify that it works for SASL_SSL without
increasing test time too much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
