nizhikov commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r433265356
##########
File path:
clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java
##########
@@ -54,21 +54,16 @@
List<Object[]> values = new ArrayList<>();
values.add(new Object[] {Collections.singletonList("TLSv1.2"),
Collections.singletonList("TLSv1.2")});
if (Java.IS_JAVA11_COMPATIBLE) {
- values.add(new Object[] {Collections.singletonList("TLSv1.2"),
Collections.singletonList("TLSv1.3")});
- values.add(new Object[] {Collections.singletonList("TLSv1.3"),
Collections.singletonList("TLSv1.2")});
- values.add(new Object[] {Collections.singletonList("TLSv1.3"),
Collections.singletonList("TLSv1.3")});
- values.add(new Object[] {Collections.singletonList("TLSv1.2"),
Arrays.asList("TLSv1.2", "TLSv1.3")});
- values.add(new Object[] {Collections.singletonList("TLSv1.3"),
Arrays.asList("TLSv1.2", "TLSv1.3")});
- values.add(new Object[] {Collections.singletonList("TLSv1.2"),
Arrays.asList("TLSv1.3", "TLSv1.2")});
- values.add(new Object[] {Collections.singletonList("TLSv1.3"),
Arrays.asList("TLSv1.3", "TLSv1.2")});
values.add(new Object[] {Arrays.asList("TLSv1.2", "TLSv1.3"),
Collections.singletonList("TLSv1.3")});
values.add(new Object[] {Arrays.asList("TLSv1.2", "TLSv1.3"),
Collections.singletonList("TLSv1.2")});
- values.add(new Object[] {Arrays.asList("TLSv1.3", "TLSv1.2"),
Collections.singletonList("TLSv1.3")});
- values.add(new Object[] {Arrays.asList("TLSv1.3", "TLSv1.2"),
Collections.singletonList("TLSv1.2")});
values.add(new Object[] {Arrays.asList("TLSv1.2", "TLSv1.3"),
Arrays.asList("TLSv1.2", "TLSv1.3")});
values.add(new Object[] {Arrays.asList("TLSv1.2", "TLSv1.3"),
Arrays.asList("TLSv1.3", "TLSv1.2")});
+
+ values.add(new Object[] {Arrays.asList("TLSv1.3", "TLSv1.2"),
Collections.singletonList("TLSv1.3")});
+ values.add(new Object[] {Arrays.asList("TLSv1.3", "TLSv1.2"),
Collections.singletonList("TLSv1.2")});
values.add(new Object[] {Arrays.asList("TLSv1.3", "TLSv1.2"),
Arrays.asList("TLSv1.2", "TLSv1.3")});
values.add(new Object[] {Arrays.asList("TLSv1.3", "TLSv1.2"),
Arrays.asList("TLSv1.3", "TLSv1.2")});
+
Review comment:
Actually, test fails for a single case:
For now, I have no idea why this happen :)
I need some time to dig into details and explain results.
Anyway, I revert the test with all possible combinations(that will fail).
```
values.add(new Object[] {Collections.singletonList("TLSv1.3"),
Arrays.asList("TLSv1.2", "TLSv1.3")});
```
This means:
```
#server config
ssl.protocol=TLSv1.3
ssl.enabled.protocols=TLSv1.3
#client config
ssl.protocol=TLSv1.2
ssl.enabled.protocols=TLSv1.2,TLSv1.3
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
