nizhikov commented on a change in pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#discussion_r433097896
##########
File path: tests/kafkatest/services/kafka/kafka.py
##########
@@ -354,15 +358,16 @@ def start_cmd(self, node):
def start_node(self, node, timeout_sec=60):
node.account.mkdirs(KafkaService.PERSISTENT_ROOT)
+
+ self.security_config.setup_node(node)
+ self.security_config.setup_credentials(node, self.path,
self.zk_connect_setting(), broker=True)
Review comment:
In the constructor of `SecurityConfig` we don't know node java version.
Therefore we should fix `tls.version` after node version known.
```
def setup_node(self, node):
...
if java_version(node) <= 11 and self.properties['tls.version'] ==
'TLSv1.3':
self.properties.update({'tls.version': 'TLSv1.2'})
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
