guozhangwang commented on a change in pull request #8971:
URL: https://github.com/apache/kafka/pull/8971#discussion_r449685553
##########
File path: tests/kafkatest/tests/streams/streams_upgrade_test.py
##########
@@ -189,9 +185,8 @@ def test_upgrade_downgrade_brokers(self, from_version,
to_version):
processor.stop()
processor.node.account.ssh_capture("grep SMOKE-TEST-CLIENT-CLOSED %s"
% processor.STDOUT_FILE, allow_fail=False)
- @matrix(from_version=metadata_1_versions,
to_version=backward_compatible_metadata_2_versions)
- @matrix(from_version=metadata_1_versions,
to_version=metadata_3_or_higher_versions)
- @matrix(from_version=metadata_2_versions,
to_version=metadata_3_or_higher_versions)
+ @matrix(from_version=metadata_1_versions, to_version=[str(DEV_VERSION)])
+ @matrix(from_version=metadata_2_versions, to_version=[str(DEV_VERSION)])
Review comment:
I was originally thinking that `streams_application_upgrade_test.py` and
`streams_upgrade_test.py` can be re-consolidated so that the latter would be
for broker-clients compatibility (including rolling upgrade the brokers), and
would for now be ignored. While the former would be used for upgrading /
downgrading clients for different paths (one rolling bounce including version
probing, two rolling bounces, full shutdown and restart). In that case, this
test and the test_version_probing_upgrade below could be moved into the other
file. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
