guozhangwang commented on a change in pull request #8971:
URL: https://github.com/apache/kafka/pull/8971#discussion_r450488992
##########
File path: tests/kafkatest/tests/streams/streams_upgrade_test.py
##########
@@ -189,9 +185,8 @@ def test_upgrade_downgrade_brokers(self, from_version,
to_version):
processor.stop()
processor.node.account.ssh_capture("grep SMOKE-TEST-CLIENT-CLOSED %s"
% processor.STDOUT_FILE, allow_fail=False)
- @matrix(from_version=metadata_1_versions,
to_version=backward_compatible_metadata_2_versions)
- @matrix(from_version=metadata_1_versions,
to_version=metadata_3_or_higher_versions)
- @matrix(from_version=metadata_2_versions,
to_version=metadata_3_or_higher_versions)
+ @matrix(from_version=metadata_1_versions, to_version=[str(DEV_VERSION)])
+ @matrix(from_version=metadata_2_versions, to_version=[str(DEV_VERSION)])
Review comment:
Yes I agree. It is not a `require` comment, I'm just leaving it since
we've been discussing about merging various tests, especially even considering
merging the StreamsSmokeTest with StreamsUpgradeTest but that can be done later.
##########
File path: tests/kafkatest/tests/streams/streams_upgrade_test.py
##########
@@ -189,9 +185,8 @@ def test_upgrade_downgrade_brokers(self, from_version,
to_version):
processor.stop()
processor.node.account.ssh_capture("grep SMOKE-TEST-CLIENT-CLOSED %s"
% processor.STDOUT_FILE, allow_fail=False)
- @matrix(from_version=metadata_1_versions,
to_version=backward_compatible_metadata_2_versions)
- @matrix(from_version=metadata_1_versions,
to_version=metadata_3_or_higher_versions)
- @matrix(from_version=metadata_2_versions,
to_version=metadata_3_or_higher_versions)
+ @matrix(from_version=metadata_1_versions, to_version=[str(DEV_VERSION)])
+ @matrix(from_version=metadata_2_versions, to_version=[str(DEV_VERSION)])
Review comment:
Yes I agree. It is not a `require` comment, I'm just leaving it since
we've been discussing about merging various tests, especially even considering
merging the StreamsSmokeTest with StreamsUpgradeTest but that is out of the
scope of this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
