vvcephei commented on a change in pull request #8971:
URL: https://github.com/apache/kafka/pull/8971#discussion_r450367500
##########
File path: tests/kafkatest/tests/streams/streams_upgrade_test.py
##########
@@ -189,9 +185,8 @@ def test_upgrade_downgrade_brokers(self, from_version,
to_version):
processor.stop()
processor.node.account.ssh_capture("grep SMOKE-TEST-CLIENT-CLOSED %s"
% processor.STDOUT_FILE, allow_fail=False)
- @matrix(from_version=metadata_1_versions,
to_version=backward_compatible_metadata_2_versions)
- @matrix(from_version=metadata_1_versions,
to_version=metadata_3_or_higher_versions)
- @matrix(from_version=metadata_2_versions,
to_version=metadata_3_or_higher_versions)
+ @matrix(from_version=metadata_1_versions, to_version=[str(DEV_VERSION)])
+ @matrix(from_version=metadata_2_versions, to_version=[str(DEV_VERSION)])
Review comment:
Ah, I see.
Since you mention the client-broker test, I was going to pose this question
to you: The test is currently ignored, as has been ignored for as long as I can
remember. It seems like we should fix it or delete it. I'm guessing your
preference would be to fix it, right?
To the point about the client-client metadata upgrade test, I left it and
the version probing test here because they are specifically testing that the
relevant metadata versions get upgraded, whereas the test I moved was instead
just about making sure that the app keeps running after an upgrade.
It does seem like we could improve the metadata and broker upgrade tests by
making them run the full soak app instead, but I'm wondering if we could do it
separately. This PR in particular seems like a good addition to add asap, since
it should dramatically reduce the number of tests we have to run during system
tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
