mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r490542749
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -200,9 +241,11 @@ class Partition(val topicPartition: TopicPartition,
// defined when this broker is leader for partition
@volatile private var leaderEpochStartOffsetOpt: Option[Long] = None
@volatile var leaderReplicaIdOpt: Option[Int] = None
- @volatile var inSyncReplicaIds = Set.empty[Int]
+ @volatile var isrState: IsrState = CommittedIsr(Set.empty)
Review comment:
Yea i was thinking we should move the ISR to a separate public accessor.
I'll change this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
