mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r490562630
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -920,7 +986,7 @@ class Partition(val topicPartition: TopicPartition,
* is violated, that replica is considered to be out of sync
*
**/
- val candidateReplicaIds = inSyncReplicaIds - localBrokerId
+ val candidateReplicaIds = isrState.maximalIsr - localBrokerId
Review comment:
Also, yes it's confusing to refer to `maximalIsr` here even though it
should always equal the committed ISR at this point (assuming we check for
inflight first).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
