mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r490561028
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -920,7 +986,7 @@ class Partition(val topicPartition: TopicPartition,
* is violated, that replica is considered to be out of sync
*
**/
- val candidateReplicaIds = inSyncReplicaIds - localBrokerId
+ val candidateReplicaIds = isrState.maximalIsr - localBrokerId
Review comment:
Makes sense, that will also satisfy your other comment about not
checking for inflight requests within the write lock
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
