ableegoldman commented on a change in pull request #9583:
URL: https://github.com/apache/kafka/pull/9583#discussion_r523130136
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##########
@@ -102,6 +107,15 @@ public StateDirectory(final StreamsConfig config, final
Time time, final boolean
log.warn("Using /tmp directory in the state.dir property can cause
failures with writing the checkpoint file" +
" due to the fact that this directory can be cleared by the
OS");
}
+ final Path basePath = Paths.get(baseDir.getPath());
+ final Path statePath = Paths.get(stateDir.getPath());
+ final Set<PosixFilePermission> perms =
PosixFilePermissions.fromString("rwxr-x---");
Review comment:
> I ran the streams test without having execute for group and I got an
exception in StreamTableJoinTopologyOptimizationIntegrationTest test
I've noticed that test is actually pretty flaky at the moment, IIRC it's
been due to a `Directory not empty` exception). So the failure you saw might
not be related to this PR. I'm pretty sure it's write permissions, not execute,
that let you delete files within a directory. Execute just lets you `cd` in and
traverse the directory. So I guess read+execute does make sense here, and
probably we wouldn't want anyone other than the owner to be able to clear the
directory anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
