mjsax commented on a change in pull request #9835:
URL: https://github.com/apache/kafka/pull/9835#discussion_r552873540
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -75,16 +75,11 @@
private final ChangelogReader changelogReader;
private final UUID processId;
private final String logPrefix;
- private final ActiveTaskCreator activeTaskCreator;
- private final StandbyTaskCreator standbyTaskCreator;
private final InternalTopologyBuilder builder;
private final Admin adminClient;
private final StateDirectory stateDirectory;
private final StreamThread.ProcessingMode processingMode;
-
- private final Map<TaskId, Task> tasks = new TreeMap<>();
- // materializing this relationship because the lookup is on the hot path
- private final Map<TopicPartition, Task> partitionToTask = new HashMap<>();
+ private final Tasks tasks;
Review comment:
The new `Tasks` class is the container -- we move the task-creators and
task-maps into this container class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
