mjsax commented on a change in pull request #9835:
URL: https://github.com/apache/kafka/pull/9835#discussion_r552885646



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##########
@@ -336,6 +340,7 @@ public void 
shouldComputeOffsetSumForUnassignedTaskWeCanLock() throws Exception
 
         replay(stateDirectory);
         taskManager.handleRebalanceStart(singleton("topic"));
+        taskManager.addTask(new StateMachineTask(taskId00, 
Collections.emptySet(), true));

Review comment:
       We have stricter check if a tasks exists now, so we need to add a task 
to avoid that `getTaskOffsetSums` fails with "unknown task exception"

##########
File path: 
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java
##########
@@ -336,6 +340,7 @@ public void 
shouldComputeOffsetSumForUnassignedTaskWeCanLock() throws Exception
 
         replay(stateDirectory);
         taskManager.handleRebalanceStart(singleton("topic"));
+        taskManager.addTask(new StateMachineTask(taskId00, 
Collections.emptySet(), true));

Review comment:
       We have stricter check if a tasks exists now, so we need to add a task 
to avoid that `getTaskOffsetSums` fails with "unknown task exception" (similar 
below)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to