mjsax commented on a change in pull request #9835:
URL: https://github.com/apache/kafka/pull/9835#discussion_r552876742
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -377,8 +370,9 @@ private void handleCloseAndRecycle(final Set<Task>
tasksToRecycle,
for (final Task task : tasksToCloseClean) {
try {
completeTaskCloseClean(task);
- cleanUpTaskProducer(task, taskCloseExceptions);
- tasks.remove(task.id());
+ if (task.isActive()) {
Review comment:
The old `cleanUpTaskProducer` contained this check, while the new
`cleanUpTaskProducerAndRemoveTask` does not -- maybe we could move the check
into the new method, but was not sure about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
