jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r552985418
##########
File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java
##########
@@ -175,6 +180,19 @@ default OptionalLong truncateToEndOffset(OffsetAndEpoch
endOffset) {
*/
Optional<RawSnapshotReader> readSnapshot(OffsetAndEpoch snapshotId) throws
IOException;
- default void close() {}
+ // TODO: write documentation
+ Optional<OffsetAndEpoch> latestSnapshotId();
+
+ /**
+ * TODO: document this method
+ * TODO document that this method is thread safe
+ */
+ void snapshotFrozen(OffsetAndEpoch snapshotId);
Review comment:
This is an implementation detail. We should be able to remove this. The
problem is that the `RawSnapshotWriter` implementation lives in the `raft`
module while the `ReplicatedLog` implementation lives in the `core` module. To
remove this we need to move `FileRawSnapshotWriter` implementation to `core`.
cc @hachikuji
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
