jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r553088258



##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -2247,7 +2346,18 @@ public synchronized OptionalLong nextExpectedOffset() {
                     return OptionalLong.empty();
                 }
             } else {
-                return OptionalLong.of(lastAckedOffset);
+                return OptionalLong.of(lastAckedEndOffset);
+            }
+        }
+
+        /**
+         * This API is used when the Listener needs to be notified of a new 
Snapshot. This happens
+         * when the context last acked end offset is less that then log start 
offset.
+         */
+        public void fireHandleSnapshot(long logStartOffset) {

Review comment:
       This is a temporary signature. This will change when we implement the 
API for loading snapshots. Tracking is work in this issue: 
https://issues.apache.org/jira/browse/KAFKA-12154




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to