jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r553077735
##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -2015,6 +2109,11 @@ private long pollUnattachedAsObserver(UnattachedState
state, long currentTimeMs)
}
private long pollCurrentState(long currentTimeMs) throws IOException {
+ // TODO: File a jira for this: Okay for now but the logic should be a
little different.
+ // Leader should only advance the log start offset if all of followers
fetched past it or there is a timeout
+ // While followers should only call maybeUpdateLogStartOffset if the
leader's logStartOffset is greater than ours
+ log.maybeUpdateLogStartOffset();
Review comment:
This implementation is okay for now but this simple implementation
should be improved by https://issues.apache.org/jira/browse/KAFKA-12155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
