chia7712 commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r564984376
##########
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java
##########
@@ -1004,10 +998,6 @@ public void testWithRecords(Args args) {
}
Review comment:
It is another test style - we can pass all parameters to all test cases
and then explicitly call assertThrow to handle the unsupported method(s). This
style can bring some benefits:
1. Single parameter suite
2. explicitly show the “unsupported” method
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
