chia7712 commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r572112317
##########
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##########
@@ -778,7 +737,7 @@ public void testBuffersDereferencedOnClose(Args args) {
int iterations = 0;
while (iterations++ < 100) {
buffer.rewind();
- MemoryRecordsBuilder builder = new MemoryRecordsBuilder(buffer,
RecordBatch.MAGIC_VALUE_V2, args.compressionType,
+ MemoryRecordsBuilder builder = new MemoryRecordsBuilder(buffer,
args.magic, args.compressionType,
TimestampType.CREATE_TIME, 0L, 0L,
RecordBatch.NO_PRODUCER_ID,
RecordBatch.NO_PRODUCER_EPOCH, RecordBatch.NO_SEQUENCE,
false, false,
RecordBatch.NO_PARTITION_LEADER_EPOCH, 0);
Review comment:
This is unrelated to this PR. However, could you replace `new byte[0]`
by `key` (line#744)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
