[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

[GitBox]

lct45 commented on a change in pull request #9253:
URL: https://github.com/apache/kafka/pull/9253#discussion_r562698730



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java
##########
@@ -327,7 +329,7 @@ public void shouldAggregateWindowed() throws Exception {
         startStreams();
 
         final List<KeyValueTimestamp<Windowed<String>, Integer>> 
windowedMessages = receiveMessagesWithTimestamp(
-            new TimeWindowedDeserializer<>(),

Review comment:
       The window size has to be set either in the constructor or in the 
configs so if we use the generics we have to use the configs, but the general 
idea was to push users to do the constructor over the configs. Also in this 
scenario, I wanted to confirm that it would work fine without configs




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org