[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

[GitBox]

lct45 commented on a change in pull request #9253:
URL: https://github.com/apache/kafka/pull/9253#discussion_r562709184



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowedDeserializerTest.java
##########
@@ -56,4 +57,23 @@ public void testWindowedValueDeserializerNoArgConstructors() 
{
         assertNotNull("Inner deserializer should be not null", inner);
         assertTrue("Inner deserializer type should be ByteArrayDeserializer", 
inner instanceof ByteArrayDeserializer);
     }
+
+    @Test
+    public void setWindowSizeThroughConfigs() {
+        props.put(StreamsConfig.WINDOW_SIZE_MS_CONFIG, "500");
+        final TimeWindowedDeserializer<?> deserializer = new 
TimeWindowedDeserializer<>();
+        deserializer.configure(props, false);

Review comment:
       Ah yeah, good catch




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org