lct45 commented on a change in pull request #9253:
URL: https://github.com/apache/kafka/pull/9253#discussion_r562699939
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java
##########
@@ -235,25 +235,27 @@ public void shouldReduceWindowed() throws Exception {
.thenComparing(KeyValueTimestamp::value);
windowedOutput.sort(comparator);
- final long firstBatchWindow = firstBatchTimestamp / 500 * 500;
- final long secondBatchWindow = secondBatchTimestamp / 500 * 500;
+ final long firstBatchWindowStart = firstBatchTimestamp / 500 * 500;
+ final long firstBatchWindowEnd = firstBatchWindowStart + 500;
Review comment:
These are time windows so it would be `windowSize`, but I didn't write
this test, just updated it to fit with the updated deserializer. I can switch
it out to `windowSize` if you think it would help with readability, WYDT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
