[GitHub] [kafka] ijuma commented on a change in pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

[GitBox]

ijuma commented on a change in pull request #10003:
URL: https://github.com/apache/kafka/pull/10003#discussion_r568862000



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -891,7 +944,7 @@ class ReplicaManager(val config: KafkaConfig,
     def processFailedRecord(topicPartition: TopicPartition, t: Throwable) = {
       val logStartOffset = getPartition(topicPartition) match {
         case HostedPartition.Online(partition) => partition.logStartOffset
-        case HostedPartition.None | HostedPartition.Offline => -1L
+        case _ => -1L

Review comment:
       I think you want to call `onlinePartition` instead of `getPartition`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org