[GitHub] [kafka] rondagostino commented on a change in pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

[GitBox]

rondagostino commented on a change in pull request #10003:
URL: https://github.com/apache/kafka/pull/10003#discussion_r568973909



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -942,7 +942,7 @@ class ReplicaManager(val config: KafkaConfig,
                                requiredAcks: Short): Map[TopicPartition, 
LogAppendResult] = {
     val traceEnabled = isTraceEnabled
     def processFailedRecord(topicPartition: TopicPartition, t: Throwable) = {
-      val logStartOffset = 
onlinePartition(topicPartition).map(_.logStartOffset).getOrElse(-1)
+      val logStartOffset: Long = 
onlinePartition(topicPartition).map(_.logStartOffset).getOrElse(-1)

Review comment:
       Doh! I was confused about why it had failed.  Will fix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org