cmccabe commented on a change in pull request #10113:
URL: https://github.com/apache/kafka/pull/10113#discussion_r574870159
##########
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##########
@@ -207,13 +207,17 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
private var currentConfig = kafkaConfig
private val dynamicConfigPasswordEncoder =
maybeCreatePasswordEncoder(kafkaConfig.passwordEncoderSecret)
- private[server] def initialize(zkClient: KafkaZkClient): Unit = {
+ private[server] def initialize(zkClient: Option[KafkaZkClient]): Unit = {
Review comment:
It seems like this function does nothing if zkClient = None is passed.
Can we simply leave the function as-is and not call it in that case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
