rondagostino commented on a change in pull request #10113:
URL: https://github.com/apache/kafka/pull/10113#discussion_r574884637



##########
File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java
##########
@@ -57,15 +57,16 @@ default void handleClaim(int epoch) {}
         /**
          * Invoked after a leader has stepped down. This callback may or may 
not
          * fire before the next leader has been elected.
+         *
+         * @param epoch the epoch that the leader is resigning from
          */
-        default void handleResign() {}
+        default void handleResign(int epoch) {}

Review comment:
       @cmccabe Should this be a `long epoch`?  That's what 
`MetaLogListener.handleRenounce(long epoch) accepts.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to