rondagostino commented on a change in pull request #10113: URL: https://github.com/apache/kafka/pull/10113#discussion_r574941168
########## File path: core/src/main/scala/kafka/server/Server.scala ########## @@ -91,4 +95,12 @@ object Server { reporters } + sealed trait ProcessStatus + case object SHUTDOWN extends ProcessStatus + case object STARTING extends ProcessStatus + case object STARTED extends ProcessStatus + case object SHUTTING_DOWN extends ProcessStatus Review comment: > Seems [`sealed trait ProcessStatus`] is only used in BrokerServer, should we move the trait there, or do we intend to use these states in the other server classes as well We'll use it in `ControllerServer` as well, so I think we should keep it here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org